[
https://issues.apache.org/jira/browse/METRON-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502453#comment-16502453
]
ASF GitHub Bot commented on METRON-1585:
----------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1050
@nickwallen Added some logging for when sensor type doesn't map to an
index. Also added a couple test cases for things like
- When a mapping is broken and the function returns nothing
- When we query for something outright missing (the test case is a bro guid
in the test sensor)
- When we provide an explicit index to `getAllLatest`. This is done by
providing a mismatched explicit index (we say it's bro, even though source type
is for test). This means that nothing will be found.
- A test case for not all of the GetRequests have a corresponding result.
> SolrRetrieveLatestDao does not use the collection lookup
> --------------------------------------------------------
>
> Key: METRON-1585
> URL: https://issues.apache.org/jira/browse/METRON-1585
> Project: Metron
> Issue Type: Sub-task
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Major
>
> `getLatest` interface has the second arg as "sensorType", but the Solr DAO
> makes the assumption that it's "collection" and renames the arg and uses it
> without retrieving the actual collection.
> https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrRetrieveLatestDao.java#L47
> `getAllLatest` at
> https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrRetrieveLatestDao.java#L47
> This can affect other DAOs that defer to this DAO (e.g. update and metaalert)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
