[ 
https://issues.apache.org/jira/browse/METRON-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502557#comment-16502557
 ] 

ASF GitHub Bot commented on METRON-1585:
----------------------------------------

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1050
  
    +1 Looks great.  Thanks!


> SolrRetrieveLatestDao does not use the collection lookup
> --------------------------------------------------------
>
>                 Key: METRON-1585
>                 URL: https://issues.apache.org/jira/browse/METRON-1585
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> `getLatest` interface has the second arg as "sensorType", but the Solr DAO 
> makes the assumption that it's "collection" and renames the arg and uses it 
> without retrieving the actual collection. 
> https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrRetrieveLatestDao.java#L47
> `getAllLatest` at 
> https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrRetrieveLatestDao.java#L47
> This can affect other DAOs that defer to this DAO (e.g. update and metaalert)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to