Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1055#discussion_r193849566
  
    --- Diff: 
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
 ---
    @@ -720,4 +719,12 @@ public int getPageSize() {
       public void setPageSize(int pageSize) {
         this.pageSize = pageSize;
       }
    +
    +  private String getField(String globalConfigKey, String defaultField) {
    --- End diff --
    
    It seems like we have duplicated this logic here and in 
`SearchServiceImpl`.  Would it make sense to extract this out?


---

Reply via email to