Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1055#discussion_r194119445
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -151,7 +152,7 @@ public GroupResponse group(GroupRequest groupRequest)
throws RestException {
String sourceTypeField = Constants.SENSOR_TYPE.replace('.', ':');
--- End diff --
This one is tricky. We can't just reference
ElasticsearchMetaAlertDao.SOURCE_TYPE because metron-elasticsearch is a runtime
dependency in metron-rest. The only other solution I can think of is to define
a second constant in Constants but I think that is confusing since it's
specific to ES. I remember @justinleet working through this in another, maybe
he can chime in.
---
