[ 
https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531959#comment-16531959
 ] 

ASF GitHub Bot commented on METRON-1650:
----------------------------------------

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1091
  
    Thank you for the contribution @jameslamb!  This failed for me when I tried 
to run it up in full dev:
    ```
    + npm install 
--prefix=/root/BUILDROOT/metron-0.5.1-root/usr/metron/0.5.1/web/expressjs 
--only=production
    /var/tmp/rpm-tmp.tvLfXe: line 60: npm: command not found
    error: Bad exit status from /var/tmp/rpm-tmp.tvLfXe (%install)
        Macro %_prerelease has empty body
        Macro %_prerelease has empty body
        Bad exit status from /var/tmp/rpm-tmp.tvLfXe (%install)
    ```
    
    I think the "Have you verified the basic functionality of the build by 
building and running locally with Vagrant full-dev environment or the 
equivalent?" item in the PR checklist is a requirement for this one.


> Packaging docker containers are too large
> -----------------------------------------
>
>                 Key: METRON-1650
>                 URL: https://issues.apache.org/jira/browse/METRON-1650
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: James Lamb
>            Priority: Minor
>
> I have been looking through the project source code, and found that the 
> packaging docker containers are bigger than they need to be. 
> The containers' size could be cut substantially by:
>  * Grouping as many commands as possible into as few RUN stages as possible
>  * Taking advantage of `yum clean` and `apt-get clean`
>  * Removing artifacts pulled with `wget`
>  * Removing unused libraries or libraries only needed at build time (like 
> `tar` and `wget`)
> I am creating this issue but will soon submit a PR to address it.
> Thank you for considering my proposal!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to