[
https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533691#comment-16533691
]
ASF GitHub Bot commented on METRON-1650:
----------------------------------------
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1091
@jameslamb,
The vagrant stuff is the general information on how to run it. For the
docker containers that you have worked on, it would be fine I think to say that
you tested that the containers work for their purpose.
It would be enough for you to say in the description:
```
Testing:
run ansible docker like this %THIS, see that it works without error
run deb docker like this %THIS, see that it works without error
run rpm docker like this %THIS, see that it works without error
```
Our vagrant build for centos and ubuntu targets actually use the rpm and
deb dockers so that is one way they get tests, but doesn't have to be the only
way.
the ansible docker must be tested explicitly
> Packaging docker containers are too large
> -----------------------------------------
>
> Key: METRON-1650
> URL: https://issues.apache.org/jira/browse/METRON-1650
> Project: Metron
> Issue Type: Improvement
> Reporter: James Lamb
> Priority: Minor
>
> I have been looking through the project source code, and found that the
> packaging docker containers are bigger than they need to be.
> The containers' size could be cut substantially by:
> * Grouping as many commands as possible into as few RUN stages as possible
> * Taking advantage of `yum clean` and `apt-get clean`
> * Removing artifacts pulled with `wget`
> * Removing unused libraries or libraries only needed at build time (like
> `tar` and `wget`)
> I am creating this issue but will soon submit a PR to address it.
> Thank you for considering my proposal!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
