[GitHub] metron pull request #1132: METRON-1695: Expose pcap properties through Ambar...

[anandsubbu]

GitHub user anandsubbu opened a pull request:

    https://github.com/apache/metron/pull/1132

    METRON-1695: Expose pcap properties through Ambari

    ## Contributor Comments
    This change add a new jinja template for the pcap properties and adds a new 
tab in Ambari Metron config for the PCAP properties. Here are the screenshots:
    <img width="853" alt="pcap-config-1" 
src="https://user-images.githubusercontent.com/20395490/43222746-a9e0026c-906e-11e8-9353-0ea34dbb4224.png";>
    <img width="988" alt="pcap-config-2" 
src="https://user-images.githubusercontent.com/20395490/43222747-aa1ba704-906e-11e8-82e8-71d4a9731aba.png";>
    
    *Testing Done*
    Built mpack out of these changes, deployed a multi-node cluster and 
validated that the pcap.properties is being updated during Parser startup 
scripts per the screenshot below:
    <img width="882" alt="parser-startup-screenshot" 
src="https://user-images.githubusercontent.com/20395490/43222878-fe5fcc50-906e-11e8-80a7-45c73e173638.png";>
    
    Also validated that the pcap properties is updated with config changes (ZK 
quorum, kafka broker etc.)
    ```
    [root@metron-12 config]# cat pcap.properties
    
    ##### Storm #####
    topology.worker.childopts=
    topology.auto-credentials=[]
    topology.workers=1
    
    ##### Kafka #####
    spout.kafka.topic.pcap=pcap
    kafka.zk=metron-10:2181,metron-11:2181,metron-1:2181
    hdfs.sync.every=1
    hdfs.replication.factor=--1
    kafka.security.protocol=PLAINTEXT
    
    # One of EARLIEST, LATEST, UNCOMMITTED_EARLIEST, UNCOMMITTED_LATEST
    kafka.pcap.start=UNCOMMITTED_EARLIEST
    
    kafka.pcap.numPackets=1000
    kafka.pcap.maxTimeMS=300000
    kafka.pcap.ts_scheme=FROM_KEY
    kafka.pcap.out=/apps/metron/pcap/input
    
    ##### Parallelism #####
    kafka.pcap.ts_granularity=MICROSECONDS
    kafka.spout.parallelism=1
    ```
    *Verification Steps*
    * Spin up full dev (or a multi-node cluster)
    * Ensure that the PCAP tab in Ambari config allows for values to be entered.
    * Deploy cluster and validate that $METRON_HOME/config/pcap.properties file 
has the proper config values set.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anandsubbu/incubator-metron METRON-1695

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1132
    
----
commit 6d5cab2eb5ebbea56faa8855115533cb7eff52ab
Author: Anand Subramanian <asubramanian@...>
Date:   2018-07-25T19:23:01Z

    METRON-1695: Expose pcap properties through Ambari

----


---