Github user anandsubbu commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1132#discussion_r205241710
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-pcap-env.xml
 ---
    @@ -0,0 +1,141 @@
    +<?xml version="1.0"?>
    +<?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
    +<!--
    +  Licensed to the Apache Software Foundation (ASF) under one
    +  or more contributor license agreements.  See the NOTICE file
    +  distributed with this work for additional information
    +  regarding copyright ownership.  The ASF licenses this file
    +  to you under the Apache License, Version 2.0 (the
    +  "License"); you may not use this file except in compliance
    +  with the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +-->
    +<configuration supports_final="true">
    +    <property>
    +        <name>pcap_topology_worker_childopts</name>
    +        <description>PCAP Topology JVM Options</description>
    +        <value/>
    +        <display-name>PCAP Topology childopts</display-name>
    +        <value-attributes>
    +            <empty-value-valid>true</empty-value-valid>
    +        </value-attributes>
    +    </property>
    +    <property>
    +        <name>pcap_topology_workers</name>
    +        <description>Number of PCAP Topology Workers</description>
    +        <value>1</value>
    +        <display-name>Workers for PCAP Topology</display-name>
    +    </property>
    +    <property>
    +        <name>spout_kafka_topic_pcap</name>
    +        <description>PCAP Input Topic</description>
    +        <value>pcap</value>
    +        <display-name>PCAP Input Topic</display-name>
    +    </property>
    +    <property>
    +        <name>hdfs_sync_every</name>
    --- End diff --
    
    The PCAP [config 
readme](https://github.com/apache/metron/tree/master/metron-platform/metron-pcap-backend#configuration)
 does not talk more about the units for this parameter (whether seconds, or 
minutes or something else). I looked through the code as well, but was not able 
to find more info. If someone could clarify about this, I can add the units so 
it is clearer.


---

Reply via email to