[ https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591751#comment-16591751 ]
ASF GitHub Bot commented on METRON-1724: ---------------------------------------- GitHub user tiborm reopened a pull request: https://github.com/apache/metron/pull/1172 METRON-1724: Date/time validation missing in PCAP query ## Contributor Comments This PR contains date range validation. We added validation messages with hints also, to help the user correct a particular input problem. <img width="1376" alt="screen shot 2018-08-15 at 3 38 30 pm" src="https://user-images.githubusercontent.com/2437400/44151039-9f5ced76-a0a1-11e8-9655-c11765987b28.png"> As a part of this changeset, we refactored pcap-filter.component to make it more aligned with some Angular best practices. We introduced ReactiveFormsModule to make form handling similar to other observable based solutions in Angular. ReactiveFormsModule also helped us to remove validation logic from the HTML template, make it part of component.ts and handle more complex validations like in case of the date range. For more details please check the following Jira ticket: https://issues.apache.org/jira/browse/METRON-1724 ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tiborm/metron METRON-1724 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1172 ---- commit 79b327fa96d6be8aea0f9bcf07f3f58ccd699581 Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:17:12Z making date picker compatible with ReactiveFormsModule commit 89310c608ba1c2354aea74c946aa94c9f15b4978 Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:18:01Z fixing tslint warnings commit cf3b1a7e802aaa803efe97b3df239f539c9d44e9 Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:27:24Z merging udpPort handlig and tslint fixes togheter commit 3394575f4ec110c884b0ef825bed8c5a70a47749 Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:27:46Z adding ReactiveFormsModule commit 6670581654f04f340f01cddb65022ef147eb6afd Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:28:08Z extending pcap-panel tests commit e0a1b25db93f475a918c8b1b4e4b71f692c8effc Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:28:29Z fixing result table typo commit 0b9cde57c40203bf5ee3de880085f5c28d665730 Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:34:59Z fixing PcapRequest types commit e2a70a16ae9c9e575ee9fa328bdf912f87ab5f75 Author: tiborm <tibor.meller@...> Date: 2018-08-22T10:38:57Z refactroring filtering, adding date range validation and validation messages commit 4ad51a4e039541c61713d30ff3ce44fd68931c4f Author: Tibor Meller <tibor.meller@...> Date: 2018-08-23T11:11:47Z renaming constants commit 40a98e5f9f8a1568168afd63eb4a35b7b5d4ff41 Author: Tibor Meller <tibor.meller@...> Date: 2018-08-23T11:42:37Z refactoring out default dates and transform functions commit 05154c0a5e08d5e2085573cf1122bfc19183337b Author: Tibor Meller <tibor.meller@...> Date: 2018-08-23T12:14:45Z removing timestamp defaul values commit d5ba708b6f79c1905078e9c6205b9c207dcf5787 Author: Tibor Meller <tibor.meller@...> Date: 2018-08-23T16:07:30Z moving transform functions back to filter commit 1e8672d980d97b2f23f87b54906b09fa34e250b6 Author: Tibor Meller <tibor.meller@...> Date: 2018-08-23T16:36:52Z adding back missing tests commit 1c030bcb47b032ae3b6ecc96b3371447c4383d2d Author: Tibor Meller <tibor.meller@...> Date: 2018-08-23T16:40:59Z fixing test names commit 12c94d4a940326d15d22f79b95223ed00f532dc3 Author: ruffle1986 <ftamas.mail@...> Date: 2018-08-24T10:12:45Z fix(pcap-filters): validate start date if end date changes and vica versa. commit 1b3662e5c3f1f37507daee899ef8ae01a0c483c6 Author: ruffle1986 <ftamas.mail@...> Date: 2018-08-24T11:24:20Z refactor: handle changes in more destricptive methods (unsubscribe in destructor) commit 5e3c6769ffc6c08df6490d75ea6e8e095f91c298 Author: ruffle1986 <ftamas.mail@...> Date: 2018-08-24T12:27:30Z add date range validation tests commit 5bb8b62430d8e314631e29f421cbd31a90d052e5 Author: Tibor Meller <tibor.meller@...> Date: 2018-08-24T13:19:21Z Merge pull request #11 from ruffle1986/fix-pcap-filter-date-range-validation-red-marks-inconsistencies fix(pcap-filters): validate start date if end date changes and vice versa ---- > Date/time validation missing in PCAP query > ------------------------------------------ > > Key: METRON-1724 > URL: https://issues.apache.org/jira/browse/METRON-1724 > Project: Metron > Issue Type: Bug > Reporter: Tibor Meller > Priority: Major > > Validation formula should be the following: > From < To < current date/time > > Validation messages: > Selected date range is invalid. The "To" date must be later than the "From" > date and the "To" date cannot be in the future. > Source IP address format is invalid. Use valid v4IP format, for example, > [192.168.0.1|http://192.168.0.1/]. > Source port is invalid. Port number must be within the range of 0-65535. > Destination IP address format is invalid. Use valid v4IP format, for example, > [192.168.0.1|http://192.168.0.1/]. > Destination port is invalid. Port number must be within the range of 0-65535. -- This message was sent by Atlassian JIRA (v7.6.3#76005)