Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1190#discussion_r216733316
  
    --- Diff: 
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java
 ---
    @@ -121,20 +131,30 @@ public void addCommentToAlert(CommentAddRemoveRequest 
request, Document latest)
         if (exceptions.size() > 0) {
           throw new IOException(Joiner.on("\n").join(exceptions));
         }
    +    return newVersions.get(0);
    --- End diff --
    
    I don't think we can safely add the Documents to `newVersions` since it is 
not a thread-safe list.


---

Reply via email to