Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1190#discussion_r216739553
--- Diff:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrUpdateDao.java
---
@@ -172,7 +174,7 @@ public void
removeCommentFromAlert(CommentAddRemoveRequest request, Document lat
// Can't remove anything if there's nothing there
if (commentMap == null) {
LOG.debug("Provided alert had no comments to be able to remove
from");
- return;
+ return null;
--- End diff --
Should we also treat this as an exceptional condition too?
---
