[ 
https://issues.apache.org/jira/browse/METRON-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617862#comment-16617862
 ] 

ASF GitHub Bot commented on METRON-1760:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1199#discussion_r218140025
  
    --- Diff: metron-interface/metron-alerts/package-lock.json ---
    @@ -5808,6 +5808,15 @@
           "integrity": "sha1-SlKCrBZHKek2Gbz9OtFR+BfOkfU=",
           "dev": true
         },
    +    "angular-confirmation-popover": {
    +      "version": "4.2.0",
    +      "resolved": 
"https://registry.npmjs.org/angular-confirmation-popover/-/angular-confirmation-popover-4.2.0.tgz";,
    +      "integrity": 
"sha512-ItCPzV52user93NRk9rF4Rp8NpawBWJdkNf8+6lH//f5i/N5HY0Aq5Hcch3xk19h9P48k0WZnfwOQL181xe4MQ==",
    +      "requires": {
    +        "positioning": "^1.3.1",
    --- End diff --
    
    Shouldn't the requirement here be for positioning 1.4.0 to patch the 
dependency you added for this?


> Kill PCAP job should prompt for confirmation
> --------------------------------------------
>
>                 Key: METRON-1760
>                 URL: https://issues.apache.org/jira/browse/METRON-1760
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Tamas Fodor
>            Assignee: Tamas Fodor
>            Priority: Major
>
> Since killing a PCAP job is a disruptive operation, it would be good to 
> prompt for user confirmation before carrying out the operation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to