[ 
https://issues.apache.org/jira/browse/METRON-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619172#comment-16619172
 ] 

ASF GitHub Bot commented on METRON-1760:
----------------------------------------

Github user ruffle1986 commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1199#discussion_r218451156
  
    --- Diff: metron-interface/metron-alerts/package-lock.json ---
    @@ -5808,6 +5808,15 @@
           "integrity": "sha1-SlKCrBZHKek2Gbz9OtFR+BfOkfU=",
           "dev": true
         },
    +    "angular-confirmation-popover": {
    +      "version": "4.2.0",
    +      "resolved": 
"https://registry.npmjs.org/angular-confirmation-popover/-/angular-confirmation-popover-4.2.0.tgz";,
    +      "integrity": 
"sha512-ItCPzV52user93NRk9rF4Rp8NpawBWJdkNf8+6lH//f5i/N5HY0Aq5Hcch3xk19h9P48k0WZnfwOQL181xe4MQ==",
    +      "requires": {
    +        "positioning": "^1.3.1",
    --- End diff --
    
    @nickwallen According to semantic versioning and how npm handles these, The 
`^` sign at the beginning of the version means that any other "minor" updates 
of Positioning are accepted by the popover but not a major change.
    
    1.4.0 is a minor update comparing to 1.3.1 since only the second number has 
been changed so npm installed and stored 1.4.0 which is the latest version and 
also the latest minor version of the package within version 1.


> Kill PCAP job should prompt for confirmation
> --------------------------------------------
>
>                 Key: METRON-1760
>                 URL: https://issues.apache.org/jira/browse/METRON-1760
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Tamas Fodor
>            Assignee: Tamas Fodor
>            Priority: Major
>
> Since killing a PCAP job is a disruptive operation, it would be good to 
> prompt for user confirmation before carrying out the operation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to