[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630703#comment-16630703
]
ASF GitHub Bot commented on METRON-1681:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1213#discussion_r220993330
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserComponent.java
---
@@ -17,26 +17,23 @@
*/
package org.apache.metron.parsers.topology;
-import java.io.Serializable;
-import org.apache.metron.parsers.bolt.WriterHandler;
import org.apache.metron.parsers.interfaces.MessageFilter;
import org.apache.metron.parsers.interfaces.MessageParser;
import org.json.simple.JSONObject;
-public class ParserComponents implements Serializable {
+import java.io.Serializable;
+
+public class ParserComponent implements Serializable {
private static final long serialVersionUID = 7880346740026374665L;
private MessageParser<JSONObject> messageParser;
private MessageFilter<JSONObject> filter;
- private WriterHandler writer;
- public ParserComponents(
+ public ParserComponent(
MessageParser<JSONObject> messageParser,
- MessageFilter<JSONObject> filter,
--- End diff --
WriterHandler was moved out of this class because it's handled by Storm.
MessageParser and MessageFilter is abstracted away from the streaming platform
in this PR.
> Decouple the ParserBolt from the Parse execution logic
> ------------------------------------------------------
>
> Key: METRON-1681
> URL: https://issues.apache.org/jira/browse/METRON-1681
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Priority: Major
>
> Per discussion on https://github.com/apache/metron/pull/1099, there are
> concerns about the ParserBolt needed some refactoring. The discussion didn't
> hold the PR up, but it was generally agreed that we should decouple some of
> the initialization and execution logic.
> This also aids us in integrating with other systems such as NiFi or Spark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
