[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630716#comment-16630716
]
ASF GitHub Bot commented on METRON-1681:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1213#discussion_r220995913
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
---
@@ -83,49 +86,21 @@ public void close() throws Exception {
List<byte[]> errors = new ArrayList<>();
public ShimParserBolt(List<byte[]> output) {
- super(null
- , Collections.singletonMap(
- sensorType == null ? config.getSensorTopic() : sensorType,
- new ParserComponents(
- ReflectionUtils.createInstance(config.getParserClassName()),
- null,
- new WriterHandler(new CollectingWriter(output))
- )
- )
- );
+ super(null, parserRunner, Collections.singletonMap(sensorType, new
WriterHandler(new CollectingWriter(output))));
--- End diff --
Not sure this ShimParserBolt is necessary anymore.
> Decouple the ParserBolt from the Parse execution logic
> ------------------------------------------------------
>
> Key: METRON-1681
> URL: https://issues.apache.org/jira/browse/METRON-1681
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Priority: Major
>
> Per discussion on https://github.com/apache/metron/pull/1099, there are
> concerns about the ParserBolt needed some refactoring. The discussion didn't
> hold the PR up, but it was generally agreed that we should decouple some of
> the initialization and execution logic.
> This also aids us in integrating with other systems such as NiFi or Spark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
