Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1234#discussion_r224528191
  
    --- Diff: 
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java
 ---
    @@ -61,16 +67,37 @@ public void configure(Map<String, Object> config) {
       public void init() {
       }
     
    -  @Override
       @SuppressWarnings("unchecked")
    +  @Override
       public List<JSONObject> parse(byte[] rawMessage) {
    +    Optional<MessageParserResult<JSONObject>> resultOptional = 
parseOptionalResult(rawMessage);
    --- End diff --
    
    It wouldn't, but the interface must be implemented.  It is awkward, I'm not 
sure how we want to proceed with that overall.  When we added the first 
parseOptional and moved the bolt to it we should have deprecated the old method 
or something....


---

Reply via email to