[GitHub] metron pull request #1234: METRON-1820 Syslog support for new api -> multipl...

[ottobackwards]

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1234#discussion_r224528495
  
    --- Diff: 
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java
 ---
    @@ -61,16 +67,37 @@ public void configure(Map<String, Object> config) {
       public void init() {
       }
     
    -  @Override
       @SuppressWarnings("unchecked")
    +  @Override
       public List<JSONObject> parse(byte[] rawMessage) {
    +    Optional<MessageParserResult<JSONObject>> resultOptional = 
parseOptionalResult(rawMessage);
    --- End diff --
    
    I'm open to a different approach, I could throw a notimplementedexception 
or something.


---