[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649438#comment-16649438
]
ASF GitHub Bot commented on METRON-1304:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r224996990
--- Diff: README.md ---
@@ -42,22 +68,47 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
The following examples highlight different ways that the plugin can be
used. Simply add the Bro script language to your `local.bro` file (for
example, `/usr/share/bro/site/local.bro`) as shown to demonstrate the example.
-### Example 1
+### Example 1 - Send a list of logs to kafka
The goal in this example is to send all HTTP and DNS records to a Kafka
topic named `bro`.
* Any configuration value accepted by librdkafka can be added to the
`kafka_conf` configuration table.
- * By defining `topic_name` all records will be sent to the same Kafka
topic.
- * Defining `logs_to_send` will ensure that only HTTP and DNS records are
sent.
+ * The `topic_name` will default to send all records to a single Kafka
topic called 'bro'.
+ * Defining `logs_to_send` will send the HTTP and DNS records to the
brokers specified in your `Kafka::kafka_conf`.
```
@load packages/metron-bro-plugin-kafka/Apache/Kafka
redef Kafka::logs_to_send = set(HTTP::LOG, DNS::LOG);
--- End diff --
The example should be for multiple brokers, not just one since that will be
the most common case won't it?
> Allow metron-bro-plugin-kafka to include or exclude logs
> --------------------------------------------------------
>
> Key: METRON-1304
> URL: https://issues.apache.org/jira/browse/METRON-1304
> Project: Metron
> Issue Type: Improvement
> Reporter: Jon Zeolla
> Assignee: Jon Zeolla
> Priority: Major
>
> Right now, you must specify which logs you want to send to kafka via
> metron-bro-plugin-kafka. This would allow the additional feature of
> excluding certain logs, and sending everything else.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
