[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649601#comment-16649601
]
ASF GitHub Bot commented on METRON-1304:
----------------------------------------
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r225017094
--- Diff: README.md ---
@@ -11,6 +11,32 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
## Installation
+### `bro-pkg` Installation
+
+`bro-pkg` is the preferred mechanism for installing this plugin, as it
will dynamically retrieve, build, test, and load the plugin. Note, that you
will still need to [activate](#activation) and configure the plugin after your
installation.
+
--- End diff --
There is a suggestion via a [user
var](https://bro-package-manager.readthedocs.io/en/stable/package.html#user-vars-field)
defined
[here](https://github.com/apache/metron-bro-plugin-kafka/blob/d1a09b6a50f20e5fa6cf5c758eea8b0d39ce65be/bro-pkg.meta#L16)
but it can be overridden during install. Whatever you provide gets passed
into the
[build_command](https://github.com/apache/metron-bro-plugin-kafka/blob/d1a09b6a50f20e5fa6cf5c758eea8b0d39ce65be/bro-pkg.meta#L5).
> Allow metron-bro-plugin-kafka to include or exclude logs
> --------------------------------------------------------
>
> Key: METRON-1304
> URL: https://issues.apache.org/jira/browse/METRON-1304
> Project: Metron
> Issue Type: Improvement
> Reporter: Jon Zeolla
> Assignee: Jon Zeolla
> Priority: Major
>
> Right now, you must specify which logs you want to send to kafka via
> metron-bro-plugin-kafka. This would allow the additional feature of
> excluding certain logs, and sending everything else.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
