[
https://issues.apache.org/jira/browse/METRON-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676964#comment-16676964
]
ASF GitHub Bot commented on METRON-1858:
----------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/1255
METRON-1858 Fix Fireeye formatting and some optimization
Reformat and fix checkstyle.
Changed to not compile patterns every parse()
All tests should pass as before, no behavior changed.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [-] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [-] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [-] Have you written or updated unit tests and or integration tests to
verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron fireeye-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1255
----
commit 1f6ced34aee604814c924d70e10a50418822abd8
Author: Otto Fowler <ottobackwards@...>
Date: 2018-11-06T15:10:35Z
Initial Formatting
commit e314cd75c050f7170bb5334bb68dc76334fd26f9
Author: Otto Fowler <ottobackwards@...>
Date: 2018-11-06T15:12:10Z
use methodhandles for logger
commit 5da4500290006c2b4082ce4e447f7fc0cb4035d5
Author: Otto Fowler <ottobackwards@...>
Date: 2018-11-06T15:38:45Z
more cleanup and refactoring
----
> BasicFireEyeParser check style cleanup and optimization
> -------------------------------------------------------
>
> Key: METRON-1858
> URL: https://issues.apache.org/jira/browse/METRON-1858
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> Compiling regex's every parse isn't not very performant and the code doesn't
> pass checkstyle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
