[
https://issues.apache.org/jira/browse/METRON-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679819#comment-16679819
]
ASF GitHub Bot commented on METRON-1858:
----------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1255
+1, this is a lot cleaner, and moving the pattern out is definitely good.
> BasicFireEyeParser check style cleanup and optimization
> -------------------------------------------------------
>
> Key: METRON-1858
> URL: https://issues.apache.org/jira/browse/METRON-1858
> Project: Metron
> Issue Type: Improvement
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
> Labels: patch-pending
>
> Compiling regex's every parse isn't not very performant and the code doesn't
> pass checkstyle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
