[ 
https://issues.apache.org/jira/browse/METRON-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680071#comment-16680071
 ] 

ASF GitHub Bot commented on METRON-1864:
----------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/1258
  
    @mmiklavc Right now the function just tests that the result is properly 
formatted (which is really all the original test did, but it just checked the 
string matched a timezone).  This will throw an exception if it's not.
    
    The problem with validating further on this test is that it's essentially 
against "now", which means that we don't know exactly what the date is, other 
than what we get back.  Anything we choose would be slightly off.
    
    We could probably refactor things around to make it possible to inject a 
given timestamp for a no arg run of the statement, but I'm not convinced that 
needs to happen to resolve the current unit test problem. 


> Stellar date format test fails after daylight saving
> ----------------------------------------------------
>
>                 Key: METRON-1864
>                 URL: https://issues.apache.org/jira/browse/METRON-1864
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.62 sec - 
> in org.apache.metron.stellar.dsl.functions.FunctionalFunctionsTest
> Results :
> Failed tests:
>  DateFunctionsTest.testDateFormatDefault:239 null



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to