[
https://issues.apache.org/jira/browse/METRON-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680012#comment-16680012
]
ASF GitHub Bot commented on METRON-1864:
----------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/1258
METRON-1864 fix issue where daylight savings breaks tests
Thanks to @justinleet for the fix. I would have use a totally awesome but
overdone regex.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [-] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [-] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron
stellar-datefunction-tz-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1258.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1258
----
commit b89068d2a52e5e6ceb7c925d6ca3e14ee8fc15f6
Author: Otto Fowler <ottobackwards@...>
Date: 2018-11-08T16:12:40Z
fix issue where daylight savings breaks tests
----
> Stellar date format test fails after daylight saving
> ----------------------------------------------------
>
> Key: METRON-1864
> URL: https://issues.apache.org/jira/browse/METRON-1864
> Project: Metron
> Issue Type: Bug
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.62 sec -
> in org.apache.metron.stellar.dsl.functions.FunctionalFunctionsTest
> Results :
> Failed tests:
> DateFunctionsTest.testDateFormatDefault:239 null
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
