Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1268#discussion_r234290697
  
    --- Diff: 
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
 ---
    @@ -916,6 +916,53 @@ public void testShortCircuit_conditional() throws 
Exception {
         Assert.assertEquals("foo", run("if NOT('metron' in [ 'metron', 
'metronicus'] ) then THROW('expression') else 'foo'", new HashMap<>()));
       }
     
    --- End diff --
    
    These tests are good, but these evaluations should be tested with other 
things in the things in the if s
    
    IF SOME_MORE_COMPLEX_FUNCTION THEN IF LAMBDA THEN MATCH ELSE B ELSE C
    To make sure we are not messing the stack up.


---

Reply via email to