Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1268#discussion_r234305980
  
    --- Diff: 
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
 ---
    @@ -916,6 +916,53 @@ public void testShortCircuit_conditional() throws 
Exception {
         Assert.assertEquals("foo", run("if NOT('metron' in [ 'metron', 
'metronicus'] ) then THROW('expression') else 'foo'", new HashMap<>()));
       }
     
    --- End diff --
    
    yeah, that is the idea.  I had to add more and more permutations ( I added 
tests for issues as @jjmeyer0 found them, or as @cestella found them )
    If you have one mega case that works that is fine.  I started out 
differently, because I had things that did not work at the beginning and I 
added later ( MAP support etc )


---

Reply via email to