[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689725#comment-16689725
]
ASF GitHub Bot commented on METRON-1875:
----------------------------------------
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234289363
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -47,47 +48,47 @@ export class PcapService {
public submitRequest(
pcapRequest: PcapRequest
): Observable<PcapStatusResponse> {
- return this.http.post('/api/v1/pcap/fixed', pcapRequest).pipe(
+ return this.http.post(this.appConfigService.getApiRoot() +
'/pcap/fixed', pcapRequest).pipe(
map(HttpUtil.extractData),
catchError(HttpUtil.handleError)
);
}
public getStatus(id: string): Observable<PcapStatusResponse> {
- return this.http.get(`/api/v1/pcap/${id}`).pipe(
+ return this.http.get(this.appConfigService.getApiRoot() +
`/pcap/${id}`).pipe(
map(HttpUtil.extractData),
catchError(HttpUtil.handleError)
);
}
public getRunningJob(): Observable<PcapStatusResponse[]> {
- return this.http.get(`/api/v1/pcap?state=RUNNING`).pipe(
+ return this.http.get(this.appConfigService.getApiRoot() +
`/pcap?state=RUNNING`).pipe(
--- End diff --
I think since you're not using multi-line strings and string interpolation
features here, it's better to use single quotes rather than a template literal.
> Expose configurable global settings in the Alerts UI
> ----------------------------------------------------
>
> Key: METRON-1875
> URL: https://issues.apache.org/jira/browse/METRON-1875
> Project: Metron
> Issue Type: Improvement
> Reporter: Ryan Merriman
> Priority: Major
>
> We need a way to change Alert UI properties without having to rebuild the
> application. There properties should be accessible within the Alerts UI code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
