[ 
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689767#comment-16689767
 ] 

ASF GitHub Bot commented on METRON-1875:
----------------------------------------

Github user sardell commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1266#discussion_r234296496
  
    --- Diff: 
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
    @@ -0,0 +1,40 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +import { Injectable } from '@angular/core';
    +import { HttpClient } from '@angular/common/http';
    +
    +@Injectable()
    +export class AppConfigService {
    +
    +  private appConfig;
    +
    +  constructor(private http: HttpClient) { }
    +
    +  loadAppConfig() {
    --- End diff --
    
    The linked article explains it perfectly. Disregard my suggestion since we 
need to be using a promise here. 


> Expose configurable global settings in the Alerts UI
> ----------------------------------------------------
>
>                 Key: METRON-1875
>                 URL: https://issues.apache.org/jira/browse/METRON-1875
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Ryan Merriman
>            Priority: Major
>
> We need a way to change Alert UI properties without having to rebuild the 
> application.  There properties should be accessible within the Alerts UI code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to