Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1247#discussion_r236521989
  
    --- Diff: 
metron-platform/metron-solr/src/test/java/org/apache/metron/solr/integration/SolrUpdateIntegrationTest.java
 ---
    @@ -186,4 +195,114 @@ public void testHugeErrorFields() throws Exception {
         exception.expectMessage("Document contains at least one immense term 
in field=\"error_hash\"");
         getDao().update(errorDoc, Optional.of("error"));
       }
    +
    +  @Test
    +  @Override
    +  public void test() throws Exception {
    --- End diff --
    
    What do these changes have to do with ES DAO read/write approach change? 
This class is testing Solr - should this be in a separate PR?


---

Reply via email to