Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1247#discussion_r236765044
  
    --- Diff: 
metron-platform/metron-solr/src/test/java/org/apache/metron/solr/integration/SolrUpdateIntegrationTest.java
 ---
    @@ -186,4 +195,114 @@ public void testHugeErrorFields() throws Exception {
         exception.expectMessage("Document contains at least one immense term 
in field=\"error_hash\"");
         getDao().update(errorDoc, Optional.of("error"));
       }
    +
    +  @Test
    +  @Override
    +  public void test() throws Exception {
    --- End diff --
    
    Ok, I found the problem. With my changes, the test data was getting loaded 
into both the ElasticsearchDao and the HBaseDao because I was using a 
MultiIndexDao to load the test data.  
    
    In master, only Elasticsearch gets loaded with the test data.  This was 
causing some of the test assumptions to fail.  I corrected how the data is 
loaded so it only loads Elasticsearch and matches the existing behavior.
    
    Thanks for pointing this out.


---

Reply via email to