nickwallen commented on a change in pull request #21: METRON-1911 Docker setup for testing bro plugin URL: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r242580376
########## File path: docker/scripts/download_sample_pcaps.sh ########## @@ -0,0 +1,105 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +shopt -s nocasematch + +# +# Downloads sample pcap files to the data directory +# + +function help { + echo " " + echo "usage: ${0}" + echo " --data-path [REQURIED] The pcap data path" + echo " -h/--help Usage information." + echo " " + echo " " +} + +DATA_PATH= + +# handle command line options +for i in "$@"; do + case $i in + # + # DATA_PATH + # + # + --data-path=*) + DATA_PATH="${i#*=}" + shift # past argument=value + ;; + + # + # -h/--help + # + -h | --help) + help + exit 0 + shift # past argument with no value + ;; + + # + # Unknown option + # + *) + UNKNOWN_OPTION="${i#*=}" + echo "Error: unknown option: $UNKNOWN_OPTION" + help + ;; + esac +done + +if [[ -z "$DATA_PATH" ]]; then + echo "DATA_PATH must be passed" + exit 1 +fi + +echo "Running download_sample_pcaps with " +echo "DATA_PATH = $DATA_PATH" +echo "===================================================" + +for folder in nitroba example-traffic ssh ftp radius rfb; do + if [[ ! -d "${DATA_PATH}"/${folder} ]]; then + mkdir -p "${DATA_PATH}"/${folder} + fi +done + +if [[ ! -f "${DATA_PATH}"/example-traffic/exercise-traffic.pcap ]]; then + wget https://www.bro.org/static/traces/exercise-traffic.pcap -O "${DATA_PATH}"/example-traffic/exercise-traffic.pcap Review comment: I don't see the data sets that I want to test with changing all that much. What I do see, is a developer making changes to the plugin and wanting to spin those changes up quickly. Having the pcaps cached in the image is going to help make that iteration much quicker. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
