nickwallen commented on a change in pull request #21: METRON-1911 Docker setup for testing bro plugin URL: https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r246055629
########## File path: docker/in_docker_scripts/configure_bro_plugin.sh ########## @@ -0,0 +1,41 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +shopt -s nocasematch + +# +# Configures the bro kafka plugin +# Configures the kafka broker +# Configures the plugin for all the traffic types +# + +echo "Configuring kafka plugin" +{ + echo "@load packages" + echo "redef Kafka::logs_to_send = set(HTTP::LOG, DNS::LOG, Conn::LOG, DPD::LOG, FTP::LOG, Files::LOG, Known::CERTS_LOG, SMTP::LOG, SSL::LOG, Weird::LOG, Notice::LOG, DHCP::LOG, SSH::LOG, Software::LOG, RADIUS::LOG, X509::LOG, Known::DEVICES_LOG, RFB::LOG, Stats::LOG, CaptureLoss::LOG, SIP::LOG);" + echo "redef Kafka::topic_name = \"bro\";" + echo "redef Kafka::tag_json = T;" + echo "redef Kafka::kafka_conf = table([\"metadata.broker.list\"] = \"kafka:9092\");" + echo "redef Kafka::logs_to_exclude = set(Conn::LOG, DHCP::LOG);" + echo "redef Known::cert_tracking = ALL_HOSTS;" + echo "redef Software::asset_tracking = ALL_HOSTS;" +} >> /usr/local/bro/share/bro/site/local.bro + + +sed -i '86 a @load policy/protocols/dhcp/known-devices-and-hostnames.bro' /usr/local/bro/share/bro/site/local.bro Review comment: Since this does work for 2.5.x, I'd suggest we just get this PR merged. We can tackle support for 2.6 in a separate PR. I'd hate for this PR to continue to drag on. But good eye @JonZeolla . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
