mmiklavc commented on a change in pull request #1275: METRON-1878: Add Metron
as a Knox service
URL: https://github.com/apache/metron/pull/1275#discussion_r243455708
##########
File path: metron-interface/metron-alerts/src/app/service/app-config.service.ts
##########
@@ -32,10 +34,19 @@ export class AppConfigService {
.toPromise()
.then(data => {
this.appConfig = data;
+ AppConfigService.appConfigStatic = data;
});
}
getApiRoot() {
return this.appConfig['apiRoot'];
}
+
+ getLoginPath() {
+ return this.appConfig['loginPath'];
Review comment:
Do you need both a static and private member ref to the config? For example,
couldn't you just make this the following?:
```
getApiRoot() {
return getAppConfigStatic()['apiRoot'];
}
getLoginPath() {
getAppConfigStatic()['loginPath'];
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
