mmiklavc commented on a change in pull request #1275: METRON-1878: Add Metron as a Knox service URL: https://github.com/apache/metron/pull/1275#discussion_r243659064
########## File path: dependencies_with_url.csv ########## @@ -495,3 +495,6 @@ org.fusesource.jansi:jansi:jar:1.16:compile,ASLv2,https://github.com/fusesource/ com.vividsolutions:jts:jar:1.13:compile joda-time:joda-time:jar:2.10:compile org.elasticsearch:securesm:jar:1.2:compile +com.github.stephenc.jcip:jcip-annotations:jar:1.0-1:compile,ASLv2,http://stephenc.github.io/jcip-annotations/ Review comment: Oh, I know what those are - I thought it sounded familiar, and it's because it's from Brian Goetz's _Java Concurrency In Practice_ - http://jcip.net/. I would imagine the jwt stuff would break at runtime without the JCIP dependency. I'm ok with this dep. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
