JonZeolla commented on a change in pull request #32: METRON-2021 add screen and configuration to image URL: https://github.com/apache/metron-bro-plugin-kafka/pull/32#discussion_r261640055
########## File path: docker/containers/bro-localbuild-container/.screenrc ########## @@ -0,0 +1,22 @@ +# terminfo and termcap for nice 256 color terminal +# allow bold colors - necessary for some reason +attrcolor b ".I" +# tell screen how to set colors. AB = background, AF=foreground Review comment: Can we add whitespace between the config lines and the blocks of comments, and clean up the extraneous whitespace at the end? Also, we should increase `defscrollback`, I usually do 20000. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
