mmiklavc commented on a change in pull request #1345: METRON-2012 Unable to
Execute Stellar Functions Against HBase in the REPL
URL: https://github.com/apache/metron/pull/1345#discussion_r262221909
##########
File path:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/WindowLookback.java
##########
@@ -94,10 +93,10 @@ public Object apply(List<Object> args, Context context)
throws ParseException {
@Override
public void initialize(Context context) {
- windowCache = CacheBuilder.newBuilder()
- .maximumSize(200)
- .expireAfterAccess(10, TimeUnit.MINUTES)
- .build();
+ windowCache = Caffeine.newBuilder()
Review comment:
It looks like you're swapping Google's cache for Caffeine - per our
performance findings in enrichments, this would be my preference as well, but
strictly speaking should this be part of a classpath and Maven dependency PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
