mmiklavc commented on a change in pull request #1345: METRON-2012 Unable to
Execute Stellar Functions Against HBase in the REPL
URL: https://github.com/apache/metron/pull/1345#discussion_r262541655
##########
File path:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/WindowLookback.java
##########
@@ -94,10 +93,10 @@ public Object apply(List<Object> args, Context context)
throws ParseException {
@Override
public void initialize(Context context) {
- windowCache = CacheBuilder.newBuilder()
- .maximumSize(200)
- .expireAfterAccess(10, TimeUnit.MINUTES)
- .build();
+ windowCache = Caffeine.newBuilder()
Review comment:
Actually, I think what you did is reasonable - it's part of the unit of
work. I didn't catch that our caching was actually part of Guava.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
