merrimanr commented on a change in pull request #1365: Metron-2050:
Automatically populate a list of enrichments from HBase
URL: https://github.com/apache/metron/pull/1365#discussion_r272725506
##########
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
##########
@@ -121,6 +121,14 @@
<empty-value-valid>true</empty-value-valid>
</value-attributes>
</property>
+ <property>
Review comment:
Why do we have a property for the HDFS url? Shouldn't we get this property
from Ambari similar to how we get Zookeeper and Kafka urls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
