merrimanr commented on a change in pull request #1365: Metron-2050:
Automatically populate a list of enrichments from HBase
URL: https://github.com/apache/metron/pull/1365#discussion_r273093306
##########
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
##########
@@ -121,6 +121,14 @@
<empty-value-valid>true</empty-value-valid>
</value-attributes>
</property>
+ <property>
Review comment:
I did not realize you were populating that in service_advisor.py. The
zookeeper and kafka urls are actually populated in params_linux.py
[here](https://github.com/apache/metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py#L129)
and
[here](https://github.com/apache/metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py#L129).
I'm not sure which approach is better or what the tradeoffs are.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
