mmiklavc commented on a change in pull request #1351: METRON-2026: Remove Storm
dependency from metron-common
URL: https://github.com/apache/metron/pull/1351#discussion_r275100538
##########
File path:
metron-platform/metron-common-streaming/metron-common-storm/src/test/java/org/apache/metron/storm/common/bolt/ConfiguredEnrichmentBoltTest.java
##########
@@ -64,15 +64,15 @@ public void reloadCallback(String name, ConfigurationType
type) {
public void setupConfiguration() throws Exception {
TestingServer testZkServer = new TestingServer(true);
this.zookeeperUrl = testZkServer.getConnectString();
- byte[] globalConfig =
ConfigurationsUtils.readGlobalConfigFromFile(TestConstants.SAMPLE_CONFIG_PATH);
+ byte[] globalConfig = ConfigurationsUtils.readGlobalConfigFromFile("../" +
TestConstants.SAMPLE_CONFIG_PATH);
Review comment:
Can we make all of these relative paths changes a local test constant? We
could probably spend more time to make this less brittle, but for now I think
it's a reasonable compromise. See
https://github.com/apache/metron/blob/master/metron-platform/metron-enrichment/metron-enrichment-storm/src/test/java/org/apache/metron/enrichment/integration/EnrichmentIntegrationTest.java#L94,
for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
