mmiklavc commented on a change in pull request #1351: METRON-2026: Remove Storm
dependency from metron-common
URL: https://github.com/apache/metron/pull/1351#discussion_r275100759
##########
File path:
metron-platform/metron-writer/src/test/java/org/apache/metron/writer/hdfs/HdfsWriterTest.java
##########
@@ -76,7 +76,8 @@ public void setup() throws IOException {
public void testGetHdfsPathNull() {
WriterConfiguration config = new IndexingWriterConfiguration(WRITER_NAME,
new IndexingConfigurations());
HdfsWriter writer = new HdfsWriter().withFileNameFormat(testFormat);
- writer.init(new HashMap<String, String>(),createTopologyContext(), config);
+ writer.init(new HashMap<String, String>(), config);
+ writer.initFileNameFormat(createTopologyContext());
Review comment:
Just for reference later - this is not part of the metron-common
refactoring, but we should remove our Storm dependencies from the writer
infrastructure as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
