mmiklavc commented on issue #1351: METRON-2026: Remove Storm dependency from metron-common URL: https://github.com/apache/metron/pull/1351#issuecomment-482767009 @merrimanr Save for a small nit with the relative paths "../" duplicated in multiple places within individual tests, I think this is pretty solid. Also looks like a small conflict with metron-platform/pom.xml. Thanks for the effort on this! You mentioned doing some light testing. Considering the classpath issues we've recently worked through, do you think it's worth running through this test script before we bring this in? https://github.com/apache/metron/pull/1368#issuecomment-477798665
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
