mmiklavc commented on issue #1351: METRON-2026: Remove Storm dependency from metron-common URL: https://github.com/apache/metron/pull/1351#issuecomment-470169072 @merrimanr - thanks for taking this on! These refactoring PR's can get pretty deep, and your work here is greatly appreciated. After a quick pass, I have a couple initial Q's/thoughts 1. I see the writer interface change to remove `TopologyContext topologyContext`. It doesn't look like we actually used that context anywhere explicitly, other than maybe the HDFSWriter. Seems like this was a pretty clean change for us in that regard. Is that the case, or can you call out any specific places where this may have caused drama? 2. `metron-storm-common` is a desirable split. What do you think about exploring following a similar packaging/module approach as was taken in `metron-parsing`. ie ``` * metron-common/ * metron-common-storm/ * metron-common-spark/ (upcoming) ``` I think that might organize things for us just a bit neater.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
