mmiklavc commented on a change in pull request #1383: METRON-1788 Batch
profiler pull profile information from zookeeper
URL: https://github.com/apache/metron/pull/1383#discussion_r280161020
##########
File path:
metron-platform/metron-common/src/test/java/org/apache/metron/common/configuration/ConfigurationsUtilsTest.java
##########
@@ -18,74 +18,71 @@
package org.apache.metron.common.configuration;
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
-
-import java.io.IOException;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Optional;
import org.adrianwalker.multilinestring.Multiline;
-import org.apache.curator.framework.CuratorFramework;
-import org.apache.curator.test.TestingServer;
import org.apache.metron.TestConstants;
import org.apache.metron.common.utils.JSONUtils;
-import org.junit.After;
-
+import org.apache.metron.integration.TestZKServer;
import org.junit.Assert;
-import org.junit.Before;
import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.junit.Assert.assertThat;
public class ConfigurationsUtilsTest {
Review comment:
Can you explain the changes in this utils test? Is this refactoring work,
and if so, what is the justification as part of this PR? These tests don't
appear to impact or be impacted by the profiler and zk config loading feature
as far as I can tell. As a general rule, we allow some degree of refactoring as
pertinent to the PR context, but other ancillary changes should typically be
split into their own PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
