mmiklavc commented on a change in pull request #1383: METRON-1788 Batch
profiler pull profile information from zookeeper
URL: https://github.com/apache/metron/pull/1383#discussion_r280205420
##########
File path:
metron-platform/metron-common/src/test/java/org/apache/metron/common/configuration/ConfigurationsUtilsTest.java
##########
@@ -18,74 +18,71 @@
package org.apache.metron.common.configuration;
-import static org.hamcrest.CoreMatchers.equalTo;
-import static org.junit.Assert.assertThat;
-
-import java.io.IOException;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Optional;
import org.adrianwalker.multilinestring.Multiline;
-import org.apache.curator.framework.CuratorFramework;
-import org.apache.curator.test.TestingServer;
import org.apache.metron.TestConstants;
import org.apache.metron.common.utils.JSONUtils;
-import org.junit.After;
-
+import org.apache.metron.integration.TestZKServer;
import org.junit.Assert;
-import org.junit.Before;
import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.junit.Assert.assertThat;
public class ConfigurationsUtilsTest {
Review comment:
My main concern for the current test setup is that other contributors may
leverage that pattern in other places and also when adding additional test
cases to the current rigs. So maybe we're at 6 seconds now and up to 10 seconds
after this change, but later it's 20, 30, and so on. I think your api idiom is
actually pretty good. If you can just split out the parts that actually
start/stop the zk component as separate calls, that would be preferable.
I definitely like the config utils test split up. So if you'd be inclined to
contribute that still, please do. The review and validation ends up being super
simple bc it's entirely confined to the existing Travis test infrastructure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
