mmiklavc commented on a change in pull request #1396: METRON-2034: REST
endpoint for getting all parser topology status should return group name
URL: https://github.com/apache/metron/pull/1396#discussion_r280192839
##########
File path: metron-platform/metron-common/src/main/config/zookeeper/global.json
##########
@@ -6,5 +6,16 @@
"update.hbase.table": "metron_update",
"update.hbase.cf": "t",
"es.client.settings": {
- }
+ },
+ "parser.groups": [
Review comment:
I think the question here then becomes why this config change is made in
this PR and not part of the UI PR that supports aggregation? If this is
literally a "the 2 PR's are tightly coupled and should be merged together"
that's probably fine. But I'm currently confused as to what the grouping change
is doing here since there doesn't seem to be an existing endpoint/feature that
this is impacting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services