mmiklavc commented on a change in pull request #1396: METRON-2034: REST
endpoint for getting all parser topology status should return group name
URL: https://github.com/apache/metron/pull/1396#discussion_r282563761
##########
File path: metron-platform/metron-common/src/main/config/zookeeper/global.json
##########
@@ -6,5 +6,16 @@
"update.hbase.table": "metron_update",
"update.hbase.cf": "t",
"es.client.settings": {
- }
+ },
+ "parser.groups": [
Review comment:
Something to explain what it is if I've never seen this config option
before, but am familiar with global config. From what you said earlier, this is
purely a sharing mechanism, not something a user should ever modify. Some of
this may be defined implicitly from the parser aggregation feature, mostly
concerned with how this additional feature functions in concert with it.
This is just off the top of my head skimming through, so I imagine you'll
have a lot more to add to it as the implementer. Some of this may already be
documented out there somewhere, just want to make sure we put a bow on it.
**User-level concerns**
1. If a user does modify it manually, whether intentionally or by accident,
what will happen?
2. What processes manage this config? Will Ambari or the config UI manage or
overwrite these values?
3. If a user adds a group manually, will the values remain, or get
overwritten/removed? (e.g. what's the interaction with our global config JSON
Patching?)
4. How is a group different from a parser aggregation as defined in the rest
of our documentation?
**Developer concerns**
1. Same as above, plus
2. What is the unique ID for a group, is there one?
3. What if I group the same sensors in multiple groups?
4. What are each of the fields and how are they used? i.e. If I go modify
this feature in the UI, what is my API and what are the guarantees it provides?
5. What fields are required vs optional? Related to the "guarantees" in 4.
Important for null checks, type checks, etc. etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
