mmiklavc commented on issue #1409: METRON-2112 Normalize parser original_string 
handling
URL: https://github.com/apache/metron/pull/1409#issuecomment-494961246
 
 
   > I ran this up in full dev and tested with the `jsonMapQuery` parser. I 
tested with the `overrideOriginalString` set to true and false and the 
`original_string` field looked correct in all cases. So everything looks good.
   > 
   > One question I have though, when would a user ever want to set 
`parser.original.string.global` to false? When I set this and 
`overrideOriginalString` to false I get an error in the ES error index but it's 
not obvious what is wrong.
   
   That is because when you have both set to false, then the `original_string` 
is never added and trips the validation rules. It's actually really good that 
you stumbled on that because, as I understand it, this is the experience of our 
users whenever they're trying to work with existing parsers or create their 
own, but trip on the validation rules. I've heard of multiple people having 
trouble tracing back the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to