mmiklavc commented on issue #1409: METRON-2112 Normalize parser original_string 
handling
URL: https://github.com/apache/metron/pull/1409#issuecomment-495346438
 
 
   > If implementing Otto's suggestion is not straightforward and needs more 
thought/discussion, I think what you've done here is fine for addressing the 
immediate need while maintaining the current behavior. I would prefer to see 
the `parser.original.string.global` option go away and just default to adding 
the raw bytes from kafka to the `original_string` field.
   
   I'm going to kill the global config option for now, but leave the 
`message.putIfAbsent()` in parserrunnerimpl. And then leave the option in 
jsonmapparser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to