nickwallen commented on a change in pull request #1441: METRON-2156: Remove
Storm dependency from metron-hbase
URL: https://github.com/apache/metron/pull/1441#discussion_r293055162
##########
File path: metron-analytics/metron-profiler-storm/pom.xml
##########
@@ -130,7 +130,7 @@
</dependency>
<dependency>
<groupId>org.apache.metron</groupId>
- <artifactId>metron-hbase</artifactId>
+ <artifactId>metron-hbase-storm</artifactId>
Review comment:
All of the classes in `metron-hbase-storm` like `HBaseBolt`, `HBaseMapper`,
`BatchHelper` are **only** used by the Profiler. These classes will never be
reused by anything else at this point. Would it make sense to just move these
to `metron-profiler-storm` and remove the new `metron-hbase-storm` project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
