nickwallen commented on a change in pull request #1441: METRON-2156: Remove
Storm dependency from metron-hbase
URL: https://github.com/apache/metron/pull/1441#discussion_r293050481
##########
File path:
metron-platform/metron-hbase/metron-hbase-common/src/test/java/org/apache/metron/hbase/client/HBaseClientTest.java
##########
@@ -149,7 +128,7 @@ public void testWrite() throws Exception {
client.mutate();
HBaseProjectionCriteria criteria = new HBaseProjectionCriteria();
- criteria.addColumnFamily(WidgetMapper.CF_STRING);
+ criteria.addColumnFamily(Bytes.toString(cf));
Review comment:
In the comments and test names in this class there are still references to
"widgets". With this refactor, nothing in here uses the Widgets or
WidgetMapper any longer. Would you be able to clean our those old references
to "widget" so as to not confuse anyone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
